Merged
Conversation
Report for GZ2E01 (a6802bf - 55d3a22)📈 Matched code: 77.67% (+0.10%, +11464 bytes) ✅ 45 new matches
...and 15 more new matches |
hatal175
reviewed
Aug 12, 2025
include/d/actor/d_a_npc_doorboy.h
Outdated
| /* 0xBEC */ u8 field_0xbec[0xbf0 - 0xbec]; | ||
| /* 0xBF0 */ daNpcF_Lookat_c mLookat; | ||
| /* 0xC8C */ daNpcF_ActorMngr_c mActorMngr[1]; | ||
| /* 0xC95 */ u8 field_0xc95[0xc98 - 0xc95]; |
Contributor
There was a problem hiding this comment.
field_0xc95 can be removed
Contributor
Author
There was a problem hiding this comment.
Removing this causes the static_assert to fail
Contributor
There was a problem hiding this comment.
This padding must exist. However, the starting offset must be 0xc94, not 0xc95, due to word alignment
hatal175
approved these changes
Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.